Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python 3.12 to allowed Python versions #10808

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Add Python 3.12 to allowed Python versions #10808

merged 1 commit into from
Oct 11, 2023

Conversation

A5rocks
Copy link
Contributor

@A5rocks A5rocks commented Oct 10, 2023 •
edited by github-actions bot
Loading

Hopefully this is the correct flow -- the comments above say to run scripts/compile_version_upload.sh but I'm not exactly sure how I do that.

If this needs to be done by someone working at RTD, feel free to close this. I was going to just make an issue but it looked easy enough to do this sort of bump!

📚 Documentation previews 📚

@A5rocks A5rocks requested review from a team as code owners October 10, 2023 03:00
@A5rocks A5rocks mentioned this pull request Oct 10, 2023
Closed
@stsewd stsewd mentioned this pull request Oct 10, 2023
Closed
@ThiefMaster ThiefMaster mentioned this pull request Oct 10, 2023
Merged
18 tasks
@agjohnson agjohnson requested review from humitos and removed request for agjohnson October 10, 2023 16:24
@agjohnson
Copy link
Contributor

I'm pinging @humitos for review on this one, given this will touch all of our build tool bundles/etc. I don't have much feedback here otherwise though.

stsewd
stsewd approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stsewd
Copy link
Member

stsewd commented Oct 10, 2023

Hopefully this is the correct flow -- the comments above say to run scripts/compile_version_upload.sh but I'm not exactly sure how I do that.

Updating and uploading the new versions was done in readthedocs/readthedocs-docker-images#198.

@humitos
Copy link
Member

humitos commented Oct 11, 2023

We can merge this PR once this CircleCI job has ran successfully: https://app.circleci.com/pipelines/github/readthedocs/readthedocs-docker-images/273/workflows/53d89e70-c7d6-445a-afcf-0d7cdaea124f/jobs/479

@humitos
Copy link
Member

humitos commented Oct 11, 2023

The sync to S3 passed. I'm merging...

@humitos humitos merged commit 14c6a9c into readthedocs:main Oct 11, 2023
3 checks passed
@ThiefMaster
Copy link

Is it already available? At least on https://docs.readthedocs.io/en/stable/config-file/v2.html#build-tools-python I don't see 3.12 yet

@humitos
Copy link
Member

humitos commented Oct 12, 2023

@ThiefMaster no, it will be available after next deploy on Tuesday.

@laymonage laymonage mentioned this pull request Nov 4, 2024
Merged
humitos added a commit that referenced this pull request Nov 14, 2024
@laymonage @humitos
Build tools: update latest versions (#11742)
5f318e4 
Ref: #11386 and #10808

Not sure if I missed anything. Looking into
`scripts/compile_version_upload.sh`, I don't know if the selected
`virtualenv` version works with 3.13 (in fact I don't know if that
package has officially supported 3.13 yet).

I initially wanted to raise an issue to support Node.js 22, but then I
got curious and thought I could help speed up the process. Feel free to
pick it up from here if there are other areas that need to be updated
e.g. https://github.com/readthedocs/readthedocs-docker-images 🙂

Closes  #11671

<!-- readthedocs-preview docs start -->
---
:books: Documentation previews :books:

- User's documentation (`docs`):
https://docs--11742.org.readthedocs.build/en/11742/

<!-- readthedocs-preview docs end -->

<!-- readthedocs-preview dev start -->
- Developer's documentation (`dev`):
https://dev--11742.org.readthedocs.build/en/11742/

<!-- readthedocs-preview dev end -->

---------

Co-authored-by: Manuel Kaufmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsewd stsewd stsewd approved these changes

@ericholscher ericholscher Awaiting requested review from ericholscher ericholscher is a code owner automatically assigned from readthedocs/advocacy

@humitos humitos Awaiting requested review from humitos

Assignees

@A5rocks A5rocks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@A5rocks @agjohnson @stsewd @humitos @ThiefMaster